use run_pip of env in executor #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures to use the correct python executable. Using `run` simply uses `sys.prefix` with a bin suffix, which is not necessarily the currently used python executable. E.g. when linking a specific python version to a custom directory, using `sys.prefix` may point to the wrong python version: * /usr/bin/python2.7 * /usr/bin/python3.6 * /usr/bin/python is a symlink to 2.7 * /usr/bin/local/python (or any other location) is a symlink to 3.6 which shadows the former symlink `sys.prefix` is `/usr` in this case, which is correct, but the `python` executable there points to the wrong version. `run_pip` in the env fixes this already by using `sys.executable`, see https://github.com/python-poetry/poetry/blob/develop/poetry/utils/env.py#L964 This should be used in the executor as well.
sdispater
approved these changes
Jul 24, 2020
sdispater
pushed a commit
that referenced
this pull request
Jul 24, 2020
This ensures to use the correct python executable. Using `run` simply uses `sys.prefix` with a bin suffix, which is not necessarily the currently used python executable. E.g. when linking a specific python version to a custom directory, using `sys.prefix` may point to the wrong python version: * /usr/bin/python2.7 * /usr/bin/python3.6 * /usr/bin/python is a symlink to 2.7 * /usr/bin/local/python (or any other location) is a symlink to 3.6 which shadows the former symlink `sys.prefix` is `/usr` in this case, which is correct, but the `python` executable there points to the wrong version. `run_pip` in the env fixes this already by using `sys.executable`, see https://github.com/python-poetry/poetry/blob/develop/poetry/utils/env.py#L964 This should be used in the executor as well.
sdispater
added a commit
that referenced
this pull request
Jul 24, 2020
This ensures to use the correct python executable. Using `run` simply uses `sys.prefix` with a bin suffix, which is not necessarily the currently used python executable. E.g. when linking a specific python version to a custom directory, using `sys.prefix` may point to the wrong python version: * /usr/bin/python2.7 * /usr/bin/python3.6 * /usr/bin/python is a symlink to 2.7 * /usr/bin/local/python (or any other location) is a symlink to 3.6 which shadows the former symlink `sys.prefix` is `/usr` in this case, which is correct, but the `python` executable there points to the wrong version. `run_pip` in the env fixes this already by using `sys.executable`, see https://github.com/python-poetry/poetry/blob/develop/poetry/utils/env.py#L964 This should be used in the executor as well. Co-authored-by: Jonathan Striebel <jstriebel@users.noreply.github.com>
|
@sdispater I was assuming that the new minor version would be on the |
@jstriebel this was already ported in #2714 the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug-fix for the current development branch and ensures to use the correct python executable.
Using
runsimply usessys.prefixwith a bin suffix, which is not necessarily the currently used python executable.E.g. when linking a specific python version to a custom directory, using
sys.prefixmay point to the wrong python version:sys.prefixis/usrin this case, which is correct, but thepythonexecutable there points to the wrong version.run_pipin the env fixes this already by usingsys.executable, see https://github.com/python-poetry/poetry/blob/develop/poetry/utils/env.py#L964This should be used in the executor as well.
Thanks for considering this change!